Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing item type in compendium throws error #1683

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Nov 5, 2024

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Changing item type in a world compendium causes error and item is moved to item sidebar rather than staying in pack

  • What is the new behavior (if this is a feature change)?
    Compendium item type changes are preserved in pack.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@marvin9257 marvin9257 merged commit b22b891 into xdy:master Nov 5, 2024
9 checks passed
@marvin9257 marvin9257 deleted the fix-compendium-change-type-fix branch November 5, 2024 20:53
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
## [5.10.2](v5.10.1...v5.10.2) (2024-11-05)

### Bug Fixes

* changing item type in compendium throws error ([#1683](#1683)) ([b22b891](b22b891))
Copy link

github-actions bot commented Nov 5, 2024

🎉 This PR is included in version 5.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant